Skip to content

add mail-from option #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 7, 2025
Merged

add mail-from option #565

merged 7 commits into from
Jan 7, 2025

Conversation

TinfoilSubmarine
Copy link
Contributor

No description provided.

@LenardHess LenardHess added enhancement New feature or request not-in-this-release Won't yet be handled in the upcoming release labels Oct 15, 2023
@LenardHess
Copy link
Contributor

This won't be added within this release.

Additionally, we are considering moving some functionality out of the core ddclient script into helper scripts.
Sending failure reports (i.e. via sendmail) will likely be one of those things.

@LenardHess LenardHess added discussion Discussions around the future/development of ddclient and removed not-in-this-release Won't yet be handled in the upcoming release labels Oct 21, 2023
rhansen
rhansen approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@rhansen rhansen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TinfoilSubmarine I rebased your commit onto latest master and pushed some fixup commits to address minor issues I noticed while reviewing. Would you please review my proposed changes and re-test? If everything looks OK to you I'll squash everything together and merge.

Thank you for the contribution, and apologies for taking so long to review.

@TinfoilSubmarine
Copy link
Contributor Author

lgtm and works in my testing

indrajitr
indrajitr approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@indrajitr indrajitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, LGTM.

TinfoilSubmarine and others added 7 commits January 6, 2025 20:20
@TinfoilSubmarine @indrajitr
add mail-from option
8030a46
@rhansen @indrajitr
fixup! add mail-from option
a2e818d 
refine usage wording
@rhansen @indrajitr
fixup! add mail-from option
2de77f1 
default to undef
@rhansen @indrajitr
fixup! add mail-from option
d1f81dc 
factor out duplicate code
@rhansen @indrajitr
fixup! add mail-from option
d2b1a4d 
move variable declaration closer to usage
@rhansen @indrajitr
fixup! add mail-from option
76fccba 
add changelog entry
@indrajitr
fixup! add main-from option
cf4bad1 
move changelog entry to v4.0.0-rc.2
@indrajitr indrajitr merged commit 4008ccf into ddclient:main Jan 7, 2025
11 checks passed
@rhansen
Copy link
Member

rhansen commented Jan 7, 2025

@indrajitr You forgot to autosquash the fixup commits. No biggie—just something to remember for next time.

@indrajitr
Copy link
Contributor

Realized right after. Apologies 😒

@chenrui333 chenrui333 mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indrajitr indrajitr indrajitr approved these changes

@rhansen rhansen rhansen approved these changes

Assignees
No one assigned
Labels
discussion Discussions around the future/development of ddclient enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TinfoilSubmarine @LenardHess @rhansen @indrajitr