It doesn't seem to match any IP addresses. Of course, the generated certificates also don't support IP addresses, so maybe it's a good thing for it to fail early when an IP address is provided as hostname

/cc @zetlen

@Js-Brecht If we don't want to match IP addresses, we can probably just add the localhost support to the existing regex? You had mentioned IP addresses in #56

Could probably switch the regex to /(?:[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?\.?)+[a-z0-9][a-z0-9-]{0,61}[a-z0-9]/i and would probably work.

I guess I did 😆. I think it will need to be done eventually, so maybe it will be good to have something on standby. Currently, though, the certificates generated do not use IP SANs. Didn't really think about that when I said it.

Could probably switch the regex to /(?:[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?\.?)+[a-z0-9][a-z0-9-]{0,61}[a-z0-9]/i and would probably work. Also, not sure if 0-9 should be in that first group?

Since, technically, domain names can have numbers in them, it makes sense to keep the 0-9.

That regexp works, but it also matches on just the first octet of an IP address like 127.0.0.1, since the final test, [a-z0-9][a-z0-9-]{0,61}[a-z0-9], requires a minimum of two characters in the last position. So IP addresses will pass the domain name check, but they won't actually be validated.

Maybe there should be a separate regex to match IP addresses, so that they can be matched prior to domain name validation? Then a friendly error could be generated to indicate that IP addresses aren't supported at the moment? Later, when they are supported, the condition could be changed to accept the IP, and a monolithic regular expression wouldn't have to be picked apart to ensure compatibility.

@Js-Brecht The regex no longer matches the octets of any IP. I also added a quick IPv4 regex and check that throws an error if an IP is provided.

Doh! Thanks, just did it quickly with the inline editor.

Ping @zetlen @davewasmer

Is there any movement on the issue?

@Js-Brecht Is there any way to move this along? This is rather inconvenient to deal with at the moment.

@stramel unfortunately, I don't have write access.

@zetlen I hate to bother you; I'm sure you're busy. This issue really is causing a lot of grief for Gatsby users, though. Would you mind taking a look at this PR so we can resolve these problems?

I'm so sorry, folks! @Js-Brecht I have been on vacation for a week, but I'll look at this right now.

Confirmed locally, this fixes the issue.

Welcome back @zetlen! Thanks for the merge 🚀; I'm sure everybody will be glad.

@stramel @Js-Brecht Published v1.1.2 to NPM.

Thank you @zetlen! Sorry for bugging you on vacation!

Ping @zetlen @davewasmer