add prefix matching method feature #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1237 +/- ##
==========================================
- Coverage 33.24% 33.21% -0.04%
==========================================
Files 42 42
Lines 11832 11844 +12
==========================================
Hits 3934 3934
- Misses 7898 7910 +12
Continue to review full report at Codecov.
|
source/helper.c
Outdated
| g_string_free(str, FALSE); | ||
| return retv; | ||
|
|
||
| return g_strconcat("\\b", g_regex_escape_string(input, -1), NULL); |
There was a problem hiding this comment.
this is a memory leak.
There was a problem hiding this comment.
Oops, not familiar with C, made a fix.
|
thanks. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the normal matching method, most of the time, there are too many results, which means more key press is needed to get what I want. With the fuzzy matching method, even more results!
So I made this prefix matching method, which can quickly narrow down the query results, help me to get the target result as less key press as possible.
Of course, add a '\b' before each keyword with regex matching method can also do the work, but apparently I will not likely to type extra same keys before each keyword.
Hope it useful for others.