Skip to content

[BUG] Including themes (.rasi vs .rasinc extension)  #2069

@flipsi

Description

@flipsi

Rofi version (rofi -v)

1.7.6-dirty

Configuration

https://gist.github.com/flipsi/ecf442bdb71121830c5e7b22b99d55a0

Theme

https://gist.github.com/flipsi/d128959fa8ee6a5cb6a769657cf77e3c

Timing report

https://gist.github.com/flipsi/0d781e139b45cdcdfc56e8107242a42e

Launch command

rofi -show window

Step to reproduce

  • Have a custom theme in the user directory, like ~/.config/rofi/themes/gruvbox-dark-purple.rasi
  • In the custom theme file, include a global theme , like @import "gruvbox-common.rasi"
  • Run any rofi command

Expected behavior

The global theme is imported correctly in rofi version 1.7.5 (I upgrade the Arch Linux package from 1.7.5-3 to 1.7.6-4 and ran into this bug).

I expect the theme import to not fail when upgrading from 1.7.5 to 1.7.6.

Actual behavior

The import fails, leading to an almost unreadable UI (due to low contrast text) with the following error:

Failed to open theme: /home/flipsi/gruvbox-common.rasi
Error: No such file or directory

Additional information

Further investigation revealed that the global theme in /usr/share/rofi/themes changed its extension, presumably it's now some compiled version for performance reasons.

So I was able to workaround the issue by changing my config from

@import "gruvbox-common.rasi"

to

@import "gruvbox-common.rasinc"

I don't know what caused this, but the changelog hasn't been updated since a few versions, so as a user one is a little lost.

What makes the failure more confusing is the fact that the error message only prints the failed file loading attempt for the user's home directory (/home/flipsi and not /usr/share/rofi/themes). So this looks like something is wrong with the searched directories or relative/absolute paths.

Using wayland display server protocol

  • No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

  • Yes, I have checked the problem exists in the latest stable version

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions