Skip to content

Improve unhandled error logging and handling #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Improve unhandled error logging and handling #1320

merged 1 commit into from
Aug 20, 2025
+14 −18

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 20, 2025

  • remove defunct FLASK_ENV handler
  • do not explicitly wrap pymongo errors
  • log all unhandled errors

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.90%. Comparing base (2b7e3f9) to head (f4b7862).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/errors.py 50.00% 1 Missing ⚠️
pydatalab/src/pydatalab/routes/v0_1/blocks.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   78.82%   78.90%   +0.07%     
==========================================
  Files          68       68              
  Lines        4681     4674       -7     
==========================================
- Hits         3690     3688       -2     
+ Misses        991      986       -5
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/errors.py 76.92% <50.00%> (+2.84%) ⬆️
pydatalab/src/pydatalab/routes/v0_1/blocks.py 65.90% <75.00%> (+2.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Aug 20, 2025 •
edited
Loading

datalab    Run #3754

Run Properties:  status check passed Passed #3754  •  git commit 5c0ce05537 ℹ️: Merge f4b78622f2c2423f059f985203980968dce5e6e2 into 2b7e3f92fab26b9dfd915b5da839...
Project datalab
Branch Review ml-evs/errors
Run status status check passed Passed #3754
Run duration 07m 42s
Commit git commit 5c0ce05537 ℹ️: Merge f4b78622f2c2423f059f985203980968dce5e6e2 into 2b7e3f92fab26b9dfd915b5da839...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@ml-evs ml-evs merged commit 1b15f3f into main Aug 20, 2025
15 checks passed
@ml-evs ml-evs deleted the ml-evs/errors branch August 20, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ml-evs