Skip to content

Add CONFIG.ROOT_PATH option to deploy API from custom path #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

Add CONFIG.ROOT_PATH option to deploy API from custom path #1315

merged 1 commit into from
Aug 15, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 14, 2025 •
edited
Loading

Closes #1312.

@ml-evs ml-evs force-pushed the ml-evs/add-root-path branch from 4c3178c to 32b7d18 Compare August 14, 2025 14:04
@ml-evs ml-evs force-pushed the ml-evs/add-root-path branch from 32b7d18 to 9623d2b Compare August 14, 2025 14:06
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.61%. Comparing base (c572c6d) to head (9623d2b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/config.py 75.00% 2 Missing ⚠️
pydatalab/src/pydatalab/routes/v0_1/auth.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
- Coverage   78.62%   78.61%   -0.01%     
==========================================
  Files          68       68              
  Lines        4673     4681       +8     
==========================================
+ Hits         3674     3680       +6     
- Misses        999     1001       +2
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/main.py 64.58% <100.00%> (ø)
pydatalab/src/pydatalab/routes/v0_1/auth.py 65.92% <50.00%> (ø)
pydatalab/src/pydatalab/config.py 81.87% <75.00%> (-0.40%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Aug 14, 2025

datalab    Run #3741

Run Properties:  status check passed Passed #3741  •  git commit 0d8fbe5258 ℹ️: Merge 9623d2b6fb6d85b1259ce9e19b84a4896ffbebc1 into c572c6d6502f6d76f951ad691d57...
Project datalab
Branch Review ml-evs/add-root-path
Run status status check passed Passed #3741
Run duration 08m 15s
Commit git commit 0d8fbe5258 ℹ️: Merge 9623d2b6fb6d85b1259ce9e19b84a4896ffbebc1 into c572c6d6502f6d76f951ad691d57...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@ml-evs ml-evs merged commit c68ee39 into main Aug 15, 2025
15 checks passed
@ml-evs ml-evs deleted the ml-evs/add-root-path branch August 15, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for running API from custom path
1 participant
@ml-evs