Skip to content

Lift restriction on passing item type when updating via /save-item #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2025
Merged

Lift restriction on passing item type when updating via /save-item #1276

merged 4 commits into from
Jul 8, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jul 8, 2025

Closes #1271

@ml-evs ml-evs added the bug Something isn't working label Jul 8, 2025
@cypress Cypress
Copy link

cypress bot commented Jul 8, 2025 •
edited
Loading

datalab    Run #3566

Run Properties:  status check passed Passed #3566  •  git commit 4f988b4d3a ℹ️: Merge 42ec7871d78e447f181c43ac33424fcb5fc1bc04 into 6dd40ceaad5a681c5f77dc63a1d5...
Project datalab
Branch Review ml-evs/api-tweaks
Run status status check passed Passed #3566
Run duration 08m 09s
Commit git commit 4f988b4d3a ℹ️: Merge 42ec7871d78e447f181c43ac33424fcb5fc1bc04 into 6dd40ceaad5a681c5f77dc63a1d5...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the ml-evs/api-tweaks branch from 5a95b8b to 08bfcc7 Compare July 8, 2025 14:48
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.36%. Comparing base (6dd40ce) to head (42ec787).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/auth.py 25.00% 3 Missing ⚠️
pydatalab/src/pydatalab/routes/v0_1/items.py 72.72% 3 Missing ⚠️
pydatalab/src/pydatalab/routes/v0_1/graphs.py 0.00% 1 Missing ⚠️
pydatalab/src/pydatalab/routes/v0_1/remotes.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   74.28%   74.36%   +0.07%     
==========================================
  Files          66       66              
  Lines        4487     4497      +10     
==========================================
+ Hits         3333     3344      +11     
+ Misses       1154     1153       -1
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/errors.py 74.07% <ø> (+11.11%) ⬆️
pydatalab/src/pydatalab/routes/v0_1/healthcheck.py 84.61% <ø> (ø)
pydatalab/src/pydatalab/routes/v0_1/graphs.py 77.94% <0.00%> (ø)
pydatalab/src/pydatalab/routes/v0_1/remotes.py 87.93% <50.00%> (+0.21%) ⬆️
pydatalab/src/pydatalab/routes/v0_1/auth.py 63.54% <25.00%> (+0.18%) ⬆️
pydatalab/src/pydatalab/routes/v0_1/items.py 81.60% <72.72%> (-0.16%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ml-evs ml-evs force-pushed the ml-evs/api-tweaks branch from 08bfcc7 to 42ec787 Compare July 8, 2025 21:50
@ml-evs ml-evs merged commit 692aebe into main Jul 8, 2025
18 checks passed
@ml-evs ml-evs deleted the ml-evs/api-tweaks branch July 8, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update item endpoint fails when item type is not part of update
1 participant
@ml-evs