Bump the uppy ecosystem to v4 and fix styling #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage ? 74.28%
=======================================
Files ? 66
Lines ? 4487
Branches ? 0
=======================================
Hits ? 3333
Misses ? 1154
Partials ? 0 🚀 New features to boost your workflow:
|
c26e15e to
cf3e07b
Compare
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/bump-uppy-to-v4
|
| Run status |
|
| Run duration | 07m 44s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to update uppy. I see that the style has changed quite a bit, but the rest of the functionality seems to work so think we just need to migrate our css a bit. The webcam UI still seems broken; the modal is not scrollable and the buttons are cut off.
Closes #31 (one our longest standing issues!) by importing the webcam plugin's CSS!
Closes #632 by updating to v4, which switches to better native mobile camera options.