Add relationships by refcode rather than item_id from the UI
#1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/synthesis-refcode
|
| Run status |
|
| Run duration | 07m 33s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
5f79ef7 to
8fde746
Compare
8fde746 to
5568c51
Compare
c470a54 to
8bd69f2
Compare
0717ff3 to
5568c51
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
+ Coverage 71.75% 71.76% +0.01%
==========================================
Files 66 66
Lines 4485 4487 +2
==========================================
+ Hits 3218 3220 +2
Misses 1267 1267
🚀 New features to boost your workflow:
|
fbd405f to
4d33805
Compare
4d33805 to
111b074
Compare
111b074 to
caff6c5
Compare
ml-evs
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
Works nicely, thanks @BenjaminCharmes! Will need to consider a migration for all existing relationships at some point (c.f. #1184), but perhaps a bit further down the line...
refcode rather than item_id from the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1173
Stock item_id and refcode in the db, but refcode has priority.