Skip to content

Bump pyupgrade to use --py310-plus, causing many type hint improvements #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 19, 2025

Related to #971. Blocked by other stacked PRs #1200 and #1199

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 93.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.09%. Comparing base (a6f25a2) to head (e9e2eee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/xrd/models.py 0.00% 11 Missing ⚠️
pydatalab/src/pydatalab/apps/xrd/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   71.20%   71.09%   -0.12%     
==========================================
  Files          65       65              
  Lines        4320     4300      -20     
==========================================
- Hits         3076     3057      -19     
+ Misses       1244     1243       -1     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/echem/blocks.py 27.45% <100.00%> (-0.71%) ⬇️
pydatalab/src/pydatalab/apps/echem/utils.py 80.76% <100.00%> (-0.37%) ⬇️
pydatalab/src/pydatalab/apps/tga/blocks.py 73.07% <100.00%> (-0.51%) ⬇️
pydatalab/src/pydatalab/apps/tga/parsers.py 94.00% <100.00%> (-0.12%) ⬇️
pydatalab/src/pydatalab/apps/xrd/blocks.py 67.00% <ø> (-0.33%) ⬇️
pydatalab/src/pydatalab/blocks/base.py 69.23% <100.00%> (+0.34%) ⬆️
pydatalab/src/pydatalab/bokeh_plots.py 81.81% <100.00%> (ø)
pydatalab/src/pydatalab/config.py 82.14% <100.00%> (ø)
pydatalab/src/pydatalab/errors.py 62.96% <100.00%> (+1.42%) ⬆️
pydatalab/src/pydatalab/file_utils.py 38.83% <100.00%> (ø)
... and 27 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented May 19, 2025

datalab    Run #3354

Run Properties:  status check passed Passed #3354  •  git commit 40aa4ade06 ℹ️: Merge e9e2eee24efe78eabecb7fd3b2c781c4d67a2803 into a6f25a26179f37669b48fa819c6b...
Project datalab
Branch Review ml-evs/pyupgrade
Run status status check passed Passed #3354
Run duration 08m 16s
Commit git commit 40aa4ade06 ℹ️: Merge e9e2eee24efe78eabecb7fd3b2c781c4d67a2803 into a6f25a26179f37669b48fa819c6b...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the ml-evs/pyupgrade branch from bb9c918 to ba69cc5 Compare May 19, 2025 17:50
@ml-evs ml-evs force-pushed the ml-evs/pyupgrade branch from ba69cc5 to e9e2eee Compare May 19, 2025 17:54
@ml-evs ml-evs merged commit 48d88a3 into main May 19, 2025
16 checks passed
@ml-evs ml-evs deleted the ml-evs/pyupgrade branch May 19, 2025 20:01
@ml-evs ml-evs added refactoring For issues/PRs that refactor existing code/features Python labels May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python refactoring For issues/PRs that refactor existing code/features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant