Set DataTable loading state when loading from store #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 65 65
Lines 4300 4300
=======================================
Hits 3057 3057
Misses 1243 1243 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/table-loading-state
|
| Run status |
|
| Run duration | 07m 54s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
2b734d1 to
7a8ed93
Compare
7e71f87 to
06ad75c
Compare
06ad75c to
7c78e97
Compare
ml-evs
commented
May 20, 2025
There was a problem hiding this comment.
Works nicely, thanks @BenjaminCharmes! Just going to make these two tweaks and then merge.
Title Optional while creating a Collection in CollectionSelect Fix cypress test Remove console.log() Tweak loading message
d22f3b0 to
70813d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1194.
@BenjaminCharmes could you take a look at rolling this out across all item types? I don't think we necessarily need to make everything async for this work, but it should be straightforward to default to
nullin the store when things are loading and[]when they are actually empty.As a side issue, the visual template for loading isn't particularly nice (grey overlay across entire component, with white text... perhaps this could be improved here too).