Skip to content

Add confirmation pop-up for file unlinking #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 14, 2025

Closes #1181

Copy link

cypress bot commented May 14, 2025

datalab    Run #3279

Run Properties:  status check passed Passed #3279  •  git commit 9ba09b1235 ℹ️: Merge eb662ee980adf997df14c015278de85d2fbe08d9 into 1f993b5842c539ec1382b98497e6...
Project datalab
Branch Review ml-evs/file-unlink-confirm
Run status status check passed Passed #3279
Run duration 07m 45s
Commit git commit 9ba09b1235 ℹ️: Merge eb662ee980adf997df14c015278de85d2fbe08d9 into 1f993b5842c539ec1382b98497e6...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@ml-evs ml-evs merged commit 1964ba5 into main May 14, 2025
15 checks passed
@ml-evs ml-evs deleted the ml-evs/file-unlink-confirm branch May 14, 2025 10:43
Copy link

codecov bot commented May 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.22%. Comparing base (1f993b5) to head (eb662ee).
⚠️ Report is 100 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files          64       64           
  Lines        4240     4240           
=======================================
  Hits         3020     3020           
  Misses       1220     1220           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add confirmation dialog when unlinking a file from an entry
1 participant