Skip to content

Fix DataTable select-all when sorting is applied #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

Fix DataTable select-all when sorting is applied #1189

merged 1 commit into from
May 18, 2025

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #1186

@codecov Codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.90%. Comparing base (c98cda0) to head (2efcf82).
⚠️ Report is 89 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1189   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files          64       64           
  Lines        4276     4276           
=======================================
  Hits         3032     3032           
  Misses       1244     1244
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented May 16, 2025 •
edited
Loading

datalab    Run #3331

Run Properties:  status check passed Passed #3331  •  git commit 30f1ed253e ℹ️: Merge 2efcf8294a6f299163d2cbe0b0eceeef39f989ea into c98cda00dd70de9a79eac584f772...
Project datalab
Branch Review bc/selectall-sorted
Run status status check passed Passed #3331
Run duration 08m 21s
Commit git commit 30f1ed253e ℹ️: Merge 2efcf8294a6f299163d2cbe0b0eceeef39f989ea into c98cda00dd70de9a79eac584f772...
Committer Ben Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review May 16, 2025 14:13
ml-evs
ml-evs approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, thakns @BenjaminCharmes! It would be nice if primevue triggered these things automatically on $nextTick when needed, but perhaps that is wishful thinking!

@ml-evs ml-evs added bug Something isn't working webapp For issues/PRs pertaining to the web interface labels May 18, 2025
@ml-evs ml-evs merged commit debf716 into main May 18, 2025
24 checks passed
@ml-evs ml-evs deleted the bc/selectall-sorted branch May 18, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees
No one assigned
Labels
bug Something isn't working webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data table select-all does not work when sort has been applied
2 participants
@BenjaminCharmes @ml-evs