Quality of life updates to the inventory: barcode display, richer data table #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 71.19% 71.22% +0.02%
==========================================
Files 64 64
Lines 4236 4240 +4
==========================================
+ Hits 3016 3020 +4
Misses 1220 1220
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/inventory-qol
|
| Run status |
|
| Run duration | 07m 36s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
ebedba3 to
61f0b0b
Compare
|
This is semi-blocked by #1124 (in that I want to use it to set the barcode to be a non-default column that user's can remember) |
1 task
61f0b0b to
da3b307
Compare
1 task
ml-evs
commented
May 7, 2025
67f4cd0 to
4bba2df
Compare
BenjaminCharmes
previously approved these changes
May 7, 2025
5055890 to
959d875
Compare
Thanks! All fixed so I'll merge when the tests pass. |
9bef01a to
17753b4
Compare
17753b4 to
9b5a872
Compare
…nnable label
- Add ability to toggle whether modal is created in formatted barcodes/qrcodes
- Add ability to show barcodes in data tables
- Disable clickable barcode modal in dynamic data table
- Fixes from code review
- Use data test ID rather than redundant CSS class
- Fix icon alignment
- Remove redundant code
Co-authored-by: Benjamin Charmes <BenjaminCharmes@users.noreply.github.com>
Add extra test case for search-items with types
9b5a872 to
48e58ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the inventory table with:
Also:
/search-itemsendpoint is returning non-matching types #1174 by properly restricting types in item search.closes Requesting to create a sample with a given duplicate refcode silently succeeds #1175 by allowing refcodes to be passed to create sample, but only to check if they already exist