Skip to content

Add labels in Datatable to be displayed in Multiselect #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

Add labels in Datatable to be displayed in Multiselect #1152

merged 2 commits into from
Apr 25, 2025

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #1151

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.35%. Comparing base (e3e39b9) to head (ee1d4e2).
Report is 91 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1152   +/-   ##
=======================================
  Coverage   71.35%   71.35%           
=======================================
  Files          63       63           
  Lines        4151     4151           
=======================================
  Hits         2962     2962           
  Misses       1189     1189
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ml-evs ml-evs added this to the v0.5.x milestone Apr 25, 2025
@cypress Cypress
Copy link

cypress bot commented Apr 25, 2025

datalab    Run #3200

Run Properties:  status check passed Passed #3200  •  git commit 9e45762fb6 ℹ️: Merge ee1d4e206509c7b65c5c20902b940ade50c253d3 into e3e39b9c2b5149d41c029739fc5a...
Project datalab
Branch Review bc/datatables-labels
Run status status check passed Passed #3200
Run duration 08m 07s
Commit git commit 9e45762fb6 ℹ️: Merge ee1d4e206509c7b65c5c20902b940ade50c253d3 into e3e39b9c2b5149d41c029739fc5a...
Committer Ben Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 498
View all changes introduced in this branch ↗︎

ml-evs
ml-evs approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this @BenjaminCharmes, LGTM!

@ml-evs ml-evs merged commit a74243b into main Apr 25, 2025
17 checks passed
@ml-evs ml-evs deleted the bc/datatables-labels branch April 25, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging this pull request may close these issues.

Multiselect don't have any labels
2 participants
@BenjaminCharmes @ml-evs