Skip to content

Better handling of duplicate key errors in item creation #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2025
Merged

Better handling of duplicate key errors in item creation #1156

merged 4 commits into from
May 14, 2025
+19 −6

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 29, 2025

Closes #1155.

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.90%. Comparing base (61b917c) to head (d7bad70).
⚠️ Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/items.py 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   70.94%   70.90%   -0.04%     
==========================================
  Files          64       64              
  Lines        4271     4276       +5     
==========================================
+ Hits         3030     3032       +2     
- Misses       1241     1244       +3
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/items.py 82.00% <66.66%> (-0.63%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Apr 29, 2025 •
edited
Loading

datalab    Run #3288

Run Properties:  status check passed Passed #3288  •  git commit 976fbec504 ℹ️: Merge d7bad7027aa87a61e58c64396599ed3037c479b3 into 61b917c591ebac837d72f2e67a54...
Project datalab
Branch Review ml-evs/catch-conflicts
Run status status check passed Passed #3288
Run duration 07m 54s
Commit git commit 976fbec504 ℹ️: Merge d7bad7027aa87a61e58c64396599ed3037c479b3 into 61b917c591ebac837d72f2e67a54...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@ml-evs ml-evs marked this pull request as ready for review May 9, 2025 15:00
@ml-evs ml-evs force-pushed the ml-evs/catch-conflicts branch from 6861f7e to 72ae671 Compare May 9, 2025 15:00
@ml-evs ml-evs force-pushed the ml-evs/catch-conflicts branch from 72ae671 to 848a2dd Compare May 14, 2025 12:39
@ml-evs ml-evs changed the title Better catch duplicate key errors Better handling of duplicate key errors in item creation May 14, 2025
@ml-evs ml-evs merged commit 4f2e022 into main May 14, 2025
17 checks passed
@ml-evs ml-evs deleted the ml-evs/catch-conflicts branch May 14, 2025 15:24
@ml-evs ml-evs added API For issues/PRs pertaining to the API refactoring For issues/PRs that refactor existing code/features labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
API For issues/PRs pertaining to the API refactoring For issues/PRs that refactor existing code/features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled duplicate key errors during item creation
1 participant
@ml-evs