Skip to content

Extend XRD block to be more flexible to different separators in xy files #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Extend XRD block to be more flexible to different separators in xy files #1137

merged 1 commit into from
Apr 22, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 22, 2025

Closes #1060.

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.35%. Comparing base (230b0b9) to head (5c9b140).
Report is 99 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
+ Coverage   71.30%   71.35%   +0.04%     
==========================================
  Files          63       63              
  Lines        4144     4151       +7     
==========================================
+ Hits         2955     2962       +7     
  Misses       1189     1189
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/xrd/blocks.py 67.32% <100.00%> (+2.43%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Apr 22, 2025

datalab    Run #3159

Run Properties:  status check passed Passed #3159  •  git commit d9d09816a1 ℹ️: Merge 5c9b140af2d229a36db62380d73c152ca903ca5a into 230b0b993b5f8bafb1f83e91bd98...
Project datalab
Branch Review ml-evs/simple-xy-xrd
Run status status check passed Passed #3159
Run duration 07m 37s
Commit git commit d9d09816a1 ℹ️: Merge 5c9b140af2d229a36db62380d73c152ca903ca5a into 230b0b993b5f8bafb1f83e91bd98...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 477
View all changes introduced in this branch ↗︎

@ml-evs ml-evs added enhancement New feature or request datablock An issue pertaining to a specific datablock labels Apr 22, 2025
@ml-evs ml-evs merged commit c2ccbc3 into main Apr 22, 2025
17 checks passed
@ml-evs ml-evs deleted the ml-evs/simple-xy-xrd branch April 22, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
datablock An issue pertaining to a specific datablock enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handling of .xy headers
1 participant
@ml-evs