Codecov Report

Attention: Patch coverage is 58.90411% with 30 lines in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (46130d9) to head (41766cf).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
+ Coverage   71.41%   71.58%   +0.16%     
==========================================
  Files          66       66              
  Lines        4440     4469      +29     
==========================================
+ Hits         3171     3199      +28     
- Misses       1269     1270       +1     

datalab    Run #3400

Run Properties:   Passed #3400  •  f75dc936e9 ℹ️: Merge 41766cfcbcd9dbf542f7be5d65c6a6893c540a8a into 46130d9df9ef70ba8117bd29d14d...

Project	datalab
Branch Review	ml-evs/simple-cif-xrd-plots
Run status	Passed #3400
Run duration	10m 12s
Commit	f75dc936e9 ℹ️: Merge 41766cfcbcd9dbf542f7be5d65c6a6893c540a8a into 46130d9df9ef70ba8117bd29d14d...
Committer	Matthew Evans
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	504
View all changes introduced in this branch ↗︎

Note to self: expose raw data in this PR

Note to self: expose raw data in this PR

Actually going to push this back to a later PR so that we can avoid holding this up

Seems to work for me! We can iterate on the UX with ability to turn on/off patterns, offset them, display ticks etc. But its a really useful thing to have in there.

When choosing all files, a warning comes up (even though it plots fine). Also, the second warning is very frequently on our data sets since they have points at 0 and the log calculation throws the warning. Can you suppress that? It gets annoying.

Seems to work for me! We can iterate on the UX with ability to turn on/off patterns, offset them, display ticks etc. But its a really useful thing to have in there.

When choosing all files, a warning comes up (even though it plots fine). Also, the second warning is very frequently on our data sets since they have points at 0 and the log calculation throws the warning. Can you suppress that? It gets annoying.

Resolved the warnings now, will merge.

You can already turn patterns on/off by clicking them in the legend, and offsetting can be done using the "normalized intensity (staggered)" y_option, though might not be perfect.

The main drawback here is that it will try to read every file attached to an item as an XRD pattern when you select "all compatible files". Fixed eventually by adding some kind of multiselect, and allowing multiple files to be attached/uploaded to a single block -- think this is a reasonable point to merge and iterate on it for the next version though.

Not totally awful if you limit it to a few patterns:

Think we need to think generally about making better use of space for plots like this though (see if we can't make the plot resizable), and use the whitespace outside for things like the legend.