Skip to content

Use importlib for plugin loading, fix test import order #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

Use importlib for plugin loading, fix test import order #1112

merged 3 commits into from
Apr 11, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 10, 2025 •
edited
Loading

Closes #1111

@ml-evs ml-evs added bug Something isn't working build For issues/PRs pertaining to the build or deployment of the package labels Apr 10, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (cb4c7cf) to head (821a536).
Report is 113 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          63       63           
  Lines        4129     4129           
=======================================
  Hits         2902     2902           
  Misses       1227     1227
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/blocks/__init__.py 96.15% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Apr 10, 2025 •
edited
Loading

datalab    Run #3087

Run Properties:  status check passed Passed #3087  •  git commit d3a8de9080 ℹ️: Merge 821a53692f4fa753821ff64f52a2916c9a03b7ee into cb4c7cfbb5aafdf6754069b2d015...
Project datalab
Branch Review ml-evs/fix-plugin-test
Run status status check passed Passed #3087
Run duration 06m 20s
Commit git commit d3a8de9080 ℹ️: Merge 821a53692f4fa753821ff64f52a2916c9a03b7ee into cb4c7cfbb5aafdf6754069b2d015...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 159
View all changes introduced in this branch ↗︎

@ml-evs ml-evs merged commit 351254a into main Apr 11, 2025
23 of 24 checks passed
@ml-evs ml-evs deleted the ml-evs/fix-plugin-test branch April 11, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminCharmes BenjaminCharmes BenjaminCharmes approved these changes

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees
No one assigned
Labels
bug Something isn't working build For issues/PRs pertaining to the build or deployment of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block plugin loading works in CI but not locally
2 participants
@ml-evs @BenjaminCharmes