NMR and XRD block improvements #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
+ Coverage 70.28% 71.30% +1.01%
==========================================
Files 63 63
Lines 4133 4144 +11
==========================================
+ Hits 2905 2955 +50
+ Misses 1228 1189 -39
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/use-tmp-for-rasx
|
| Run status |
|
| Run duration | 07m 19s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
477
|
| View all changes introduced in this branch ↗︎ | |
|
Probably one for @jdbocarsly and @be-smith to review when you get a moment |
be-smith
previously approved these changes
Apr 15, 2025
BenjaminCharmes
previously approved these changes
Apr 15, 2025
e2d0edf to
b7ff5eb
Compare
|
Made a couple of tweaks to testing since your reviews @be-smith and @BenjaminCharmes, will also wait for @jdbocarsly sign off anyway |
BenjaminCharmes
approved these changes
Apr 17, 2025
jdbocarsly
approved these changes
Apr 17, 2025
…vert to original behaviour if block has no file
b7ff5eb to
0568f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main one being using a temp dir when extracting data, to avoid clogging up the server.
Also improve the NMR block plots and nest metadata under their own key (which the app will now try to use by default in the UI, falling back to the original).