Skip to content

Make the regex item search the default, and use '%' for full text search #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 18, 2025
Merged

Make the regex item search the default, and use '%' for full text search #1103

merged 6 commits into from
Apr 18, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 9, 2025 •
edited
Loading

Closes #679 IMO.

@cypress Cypress
Copy link

cypress bot commented Apr 9, 2025 •
edited
Loading

datalab    Run #3137

Run Properties:  status check passed Passed #3137  •  git commit 2270dec013 ℹ️: Merge 55a0414fb9f598a5ffa2107c28d7c9b59d926b98 into 799aaf686333870c4fb29b9d1d51...
Project datalab
Branch Review ml-evs/make-regex-search-default
Run status status check passed Passed #3137
Run duration 07m 53s
Commit git commit 2270dec013 ℹ️: Merge 55a0414fb9f598a5ffa2107c28d7c9b59d926b98 into 799aaf686333870c4fb29b9d1d51...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 477
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the ml-evs/make-regex-search-default branch from 4c94d24 to f14b6a0 Compare April 17, 2025 13:32
@ml-evs ml-evs mentioned this pull request Apr 17, 2025
Closed
@ml-evs ml-evs force-pushed the ml-evs/make-regex-search-default branch from 37e8887 to 47027e4 Compare April 17, 2025 15:28
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.30%. Comparing base (799aaf6) to head (55a0414).
Report is 101 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          63       63           
  Lines        4144     4144           
=======================================
  Hits         2955     2955           
  Misses       1189     1189
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/mongo.py 80.00% <ø> (ø)
pydatalab/src/pydatalab/routes/v0_1/items.py 83.38% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ml-evs ml-evs merged commit a50414b into main Apr 18, 2025
17 checks passed
@ml-evs ml-evs deleted the ml-evs/make-regex-search-default branch April 18, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Free text search could be improved
1 participant
@ml-evs