Skip to content

Fixed calling _format_ftir_plot method named when called to show data #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

be-smith
Copy link
Contributor

@be-smith be-smith commented Apr 9, 2025

Bug due to me renaming the _formati_ftir_plot method but not updating when it's actually called in the block itself

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (53a985f) to head (691adc6).
Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/ftir/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1107   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          63       63           
  Lines        4129     4129           
=======================================
  Hits         2902     2902           
  Misses       1227     1227           
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/ftir/__init__.py 68.75% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Apr 9, 2025

datalab    Run #3076

Run Properties:  status check passed Passed #3076  •  git commit d58826e6f0 ℹ️: Merge 691adc6f3a8eb953aeb4507108b132f515f657cc into 53a985f6b09a3c8c3cf3ae742af9...
Project datalab
Branch Review bes/ftir_fix
Run status status check passed Passed #3076
Run duration 07m 46s
Commit git commit d58826e6f0 ℹ️: Merge 691adc6f3a8eb953aeb4507108b132f515f657cc into 53a985f6b09a3c8c3cf3ae742af9...
Committer Ben Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 477
View all changes introduced in this branch ↗︎

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this indeed highlights the need to refactor some of our tests to properly test block usage. Thanks!

@ml-evs ml-evs marked this pull request as ready for review April 9, 2025 19:20
@ml-evs ml-evs merged commit 8ee15c2 into main Apr 9, 2025
17 checks passed
@ml-evs ml-evs deleted the bes/ftir_fix branch April 9, 2025 22:42
@ml-evs ml-evs added bug Something isn't working datablock An issue pertaining to a specific datablock labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datablock An issue pertaining to a specific datablock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants