Skip to content

Add search link to CAS Common Chemistry when CAS provided #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 9, 2025

Looks like this:

2025-04-09.15-34-01.mp4

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (ccd933c) to head (8ce4db1).
Report is 112 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          63       63           
  Lines        4129     4129           
=======================================
  Hits         2902     2902           
  Misses       1227     1227           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Apr 9, 2025

datalab    Run #3068

Run Properties:  status check passed Passed #3068  •  git commit 4c29fa8d07 ℹ️: Merge 8ce4db1156b6325758f39d8ba7faf634affcc7aa into ccd933c60222ee1e124b5409f7f6...
Project datalab
Branch Review ml-evs/cas-link
Run status status check passed Passed #3068
Run duration 07m 03s
Commit git commit 4c29fa8d07 ℹ️: Merge 8ce4db1156b6325758f39d8ba7faf634affcc7aa into ccd933c60222ee1e124b5409f7f6...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 477
View all changes introduced in this branch ↗︎

Copy link
Member

@jdbocarsly jdbocarsly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Excited for when we can query an API and pull this info into datalab itself

@ml-evs
Copy link
Member Author

ml-evs commented Apr 9, 2025

looks good! Excited for when we can query an API and pull this info into datalab itself

I looked into this again and signed up at https://www.cas.org/services/commonchemistry-api but might need to be careful that we're not crossing into commercial use

@ml-evs ml-evs added enhancement New feature or request webapp For issues/PRs pertaining to the web interface labels Apr 9, 2025
@ml-evs ml-evs merged commit bb58701 into main Apr 9, 2025
17 checks passed
@ml-evs ml-evs deleted the ml-evs/cas-link branch April 9, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants