Add components to data tables for showing block and file count #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 63 63
Lines 4129 4129
=======================================
Hits 2902 2902
Misses 1227 1227
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/block-file-counter
|
| Run status |
|
| Run duration | 07m 02s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
477
|
| View all changes introduced in this branch ↗︎ | |
|
@ml-evs I've added the function to filter by blockType as we discussed yesterday, don't hesitate to tell me what you think and if you want me to change anything. |
Great, will check it out! |
e147e5e to
4917b99
Compare
|
Awesome, thanks for this @BenjaminCharmes! I'm going to merge this so I can get feedback straight away, maybe we can iterate on the visuals before/after the next release. |
Fix cypress e2e editPage Fix SampleTable and StartingMaterialTable cypress component test
4917b99 to
3d128a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1077 and closes #1095