Fix plugin loading not triggering on server startup #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
==========================================
+ Coverage 70.25% 70.28% +0.02%
==========================================
Files 63 63
Lines 4129 4129
==========================================
+ Hits 2901 2902 +1
+ Misses 1228 1227 -1
🚀 New features to boost your workflow:
|
ml-evs
reviewed
Apr 4, 2025
ml-evs
reviewed
Apr 4, 2025
|
Found the issue with the tests! The docker container does not have |
Remove warning when block already loaded Remove warning when block already loaded Re-add warning when block already loaded Always add every loaded plugin to block_plugins
…'t displayed on a single line
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/insitu-load
|
| Run status |
|
| Run duration | 08m 29s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
471
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1084
insitu-nmrplugin is correctly loaded on server startup.Updates plugin name in
resources.jsandNMRInsituBlock.vue[WIP]: