-
Notifications
You must be signed in to change notification settings - Fork 22
Add in situ NMR DataBlock as an app plugin #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
+ Coverage 70.14% 70.18% +0.03%
==========================================
Files 63 63
Lines 4107 4119 +12
==========================================
+ Hits 2881 2891 +10
- Misses 1226 1228 +2
🚀 New features to boost your workflow:
|
b6f4528
to
ca6b189
Compare
datalab
|
Project |
datalab
|
Branch Review |
bc/nmr-insitu
|
Run status |
|
Run duration | 06m 20s |
Commit |
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
157
|
View all changes introduced in this branch ↗︎ |
fe52c69
to
35d4931
Compare
ml-evs
reviewed
Mar 26, 2025
7 tasks
ml-evs
reviewed
Mar 26, 2025
2a8f520
to
f1b1f8d
Compare
Add missing import Add double bokeh_plot to insitu block Add fitting plot to insitu block Bokeh plot with echem + nmr spectrum Add every bokeh_plot for insitu block Add every bokeh_plot for insitu block Tidy up Add shared y_range between echem and nmr plot Add temp. nmr_folder_name and echem_folder_name Remove button use folder_name and file_id to find the folder in the API Update uv.lock Use new plugin fct process_datalab_data Add spectrum plot when user click on heatmap Better way of displaying data in insitu block Replace input with v-select for folder_name Change colormapper while zooming Fix a few thing Re-add ppm1/ppm2 Add nmrplot on heatmap click Add delete line in nmrplot by clicking on it Update on click Change color palette Remove /apps/insitu Import InsituBlock from plugin Rename insitu plugin
ml-evs
reviewed
Mar 31, 2025
- Add datalab_app_plugin_insitu pinned to v0.1.1
ml-evs
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @BenjaminCharmes
This was referenced Mar 31, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Insitu NMR DataBlock using new datalab insitu plugin