Skip to content

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Jan 23, 2025

Add a new Insitu NMR DataBlock using new datalab insitu plugin

Screenshot 2025-03-18 at 15 55 26

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (da2b63f) to head (2f7ffc9).
Report is 134 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/blocks/__init__.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
+ Coverage   70.14%   70.18%   +0.03%     
==========================================
  Files          63       63              
  Lines        4107     4119      +12     
==========================================
+ Hits         2881     2891      +10     
- Misses       1226     1228       +2     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/blocks/__init__.py 92.30% <86.66%> (-7.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Jan 23, 2025

datalab    Run #3003

Run Properties:  status check passed Passed #3003  •  git commit 71e387f9f8 ℹ️: Merge 2f7ffc9e0ac0947475c38d29bf41ac5341707563 into da2b63f230916093bc4be911664f...
Project datalab
Branch Review bc/nmr-insitu
Run status status check passed Passed #3003
Run duration 06m 20s
Commit git commit 71e387f9f8 ℹ️: Merge 2f7ffc9e0ac0947475c38d29bf41ac5341707563 into da2b63f230916093bc4be911664f...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 157
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes changed the title [WIP] Insitu NMR DataBlock Add Insitu NMR DataBlock Mar 28, 2025
@ml-evs ml-evs force-pushed the bc/nmr-insitu branch 2 times, most recently from 2a8f520 to f1b1f8d Compare March 30, 2025 18:39
@ml-evs ml-evs changed the title Add Insitu NMR DataBlock Add in situ NMR DataBlock as an app plugin Mar 30, 2025
@ml-evs ml-evs added enhancement New feature or request datablock An issue pertaining to a specific datablock labels Mar 30, 2025
@ml-evs ml-evs marked this pull request as ready for review March 30, 2025 18:39
@ml-evs ml-evs requested a review from jdbocarsly as a code owner March 30, 2025 18:39
Add missing import

Add double bokeh_plot to insitu block

Add fitting plot to insitu block

Bokeh plot with echem + nmr spectrum

Add every bokeh_plot for insitu block

Add every bokeh_plot for insitu block

Tidy up

Add shared y_range between echem and nmr plot

Add temp. nmr_folder_name and echem_folder_name

Remove button

use folder_name and file_id to find the folder in the API

Update uv.lock

Use new plugin fct process_datalab_data

Add spectrum plot when user click on heatmap

Better way of displaying data in insitu block

Replace input with v-select for folder_name

Change colormapper while zooming

Fix a few thing

Re-add ppm1/ppm2

Add nmrplot on heatmap click

Add delete line in nmrplot by clicking on it

Update on click

Change color palette

Remove /apps/insitu

Import InsituBlock from plugin

Rename insitu plugin
- Add datalab_app_plugin_insitu pinned to v0.1.1
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @BenjaminCharmes

@ml-evs ml-evs merged commit 8623b8f into main Mar 31, 2025
23 of 24 checks passed
@ml-evs ml-evs deleted the bc/nmr-insitu branch March 31, 2025 19:16
@ml-evs ml-evs mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datablock An issue pertaining to a specific datablock enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants