Reset unsaved warning after getSampleData() receives data
#606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
jdb/fix_iss601
|
| Run status |
|
| Run duration | 07m 30s |
| Commit |
|
| Committer | Josh Bocarsly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
477
|
| View all changes introduced in this branch ↗︎ | |
|
@ml-evs , can you deploy this to dev when you get a chance? Would like to test it on a real server with latency, etc. |
b43f7b6 to
fbdc3d2
Compare
Deployed on dev |
fbdc3d2 to
4ff447c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 67.24% 67.24%
=======================================
Files 62 62
Lines 3749 3749
=======================================
Hits 2521 2521
Misses 1228 1228 |
a10c3fd to
8b5ef72
Compare
…t is reset after the SynthesisInformation watcher fires
8b5ef72 to
ce8b215
Compare
|
Ok this is ready for review. The approach I took here is just to reset the warning on reload, which is the simplest approach. Note that we still don't clear the store. This may have pluses and minuses that could be considered for other behavior, but the unsaved warning issue seems to be fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 63 63
Lines 4129 4129
=======================================
Hits 2902 2902
Misses 1227 1227 🚀 New features to boost your workflow:
|
getSampleData() receives data
ml-evs
approved these changes
Apr 9, 2025
BenjaminCharmes
pushed a commit
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to prevent the annoying bug where the unsaved warning erroneously appears whenever a sample or cell page is loaded a second time without a refresh.
closes #601