incremented width in sizedBox to add some more padding. #2861
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
pkgs/sketch_pad/lib/main.dart
Outdated
| @@ -143,7 +143,7 @@ class _DartPadAppState extends State<DartPadApp> { | |||
| ColorScheme.fromSeed(seedColor: lightPrimaryColor).copyWith( | |||
| surface: lightSurfaceColor, | |||
| onSurface: Colors.black, | |||
| surfaceVariant: lightSurfaceVariantColor, | |||
| surfaceContainerHighest: Colors.blue, | |||
There was a problem hiding this comment.
Why this change (and the similar one below)?
There was a problem hiding this comment.
I was getting an error in pipeline it was showing an error , which was exactly like this :-
info • 'surfaceVariant' is deprecated and shouldn't be used. Use surfaceContainerHighest instead. This feature was deprecated after v3.18.0-0.1.pre • lib/main.dart:146:11 • deprecated_member_use
info • 'surfaceVariant' is deprecated and shouldn't be used. Use surfaceContainerHighest instead. This feature was deprecated after v3.18.0-0.1.pre • lib/main.dart:167:11 • deprecated_member_use
info • 'surfaceVariant' is deprecated and shouldn't be used. Use surfaceContainerHighest instead. This feature was deprecated after v3.18.0-0.1.pre • lib/problems.dart:46:30 •
There was a problem hiding this comment.
I thought may be changing it would resolve the error , shall I revert this changes but I'm not sure whether the pipeline would run successfully ?
There was a problem hiding this comment.
I'd revert this change; the bots will check for any deprecation messages (and we can address in a separate PR if necessary).
There was a problem hiding this comment.
It looks like we hit this in another PR as well: https://github.com/dart-lang/dart-pad/pull/2870/files#diff-ed60136a3d9ee7c71a9ed356332807808330f0cb99e3959050cfe26b087d6f8eR146. You could wait until that lands and then update your branch w/ the contents of main.
| @@ -124,7 +124,7 @@ class RunButton extends StatelessWidget { | |||
| size: 20.0, | |||
| ), | |||
| SizedBox( | |||
| width: 8.0, | |||
| width: 16.0, | |||
There was a problem hiding this comment.
https://github.com/dart-lang/dart-pad/pull/2870/files#diff-ed60136a3d9ee7c71a9ed356332807808330f0cb99e3959050cfe26b087d6f8eR146 . I believe this PR has been merged now and I have resolved the merge conflicts wrt main.
There was a problem hiding this comment.
that surfaceVariant check is again failing
|
Thanks for giving me the opportunity to work , this happens to be my first open source contribution |
Issue:- add more right padding to the 'run' button #2840
link:- #2840
Added more padding to the run button in dart pad.