Skip to content

Rollback K8s version in AKS bicep file #5104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2022
Merged

Rollback K8s version in AKS bicep file #5104

merged 2 commits into from
Sep 1, 2022

Conversation

johnewart
Copy link
Contributor

Run e2e tests in previous version of K8s on AKS to see if it's breaking Windows tests. Opening as a draft PR to re-run test suites using our pipeline with the old version.

Description

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Merging #5104 (a589875) into master (490ef74) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a589875 differs from pull request most recent head 762cdf1. Consider uploading reports for the commit 762cdf1 to get more accurate results

@@            Coverage Diff             @@
##           master    #5104      +/-   ##
==========================================
- Coverage   65.42%   65.41%   -0.01%     
==========================================
  Files         114      114              
  Lines       12762    12761       -1     
==========================================
- Hits         8349     8348       -1     
  Misses       3826     3826              
  Partials      587      587
Impacted Files Coverage Δ
pkg/runtime/runtime.go 67.21% <0.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@artursouza
Copy link
Contributor

/ok-to-test

4 similar comments
@artursouza
Copy link
Contributor

/ok-to-test

@artursouza
Copy link
Contributor

/ok-to-test

@artursouza
Copy link
Contributor

/ok-to-test

@artursouza
Copy link
Contributor

/ok-to-test

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

End-to-end tests failed on windows. Please check the build logs

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

End-to-end tests failed on windows. Please check the build logs

artursouza
artursouza previously approved these changes Sep 1, 2022
View reviewed changes
@artursouza artursouza changed the title [Do not merge] Rollback K8s version in AKS bicep file Rollback K8s version in AKS bicep file Sep 1, 2022
@johnewart
Run e2e tests in previous version of K8s on AKS to see if it's breaki…
156bbfd 
…ng Windows tests

Signed-off-by: John Ewart <john@johnewart.net>
@artursouza artursouza marked this pull request as ready for review September 1, 2022 20:14
@artursouza artursouza requested review from a team as code owners September 1, 2022 20:14
@artursouza artursouza merged commit 7c4f155 into dapr:master Sep 1, 2022
Taction added a commit to Taction/dapr that referenced this pull request Sep 5, 2022
@Taction
Merge branch 'master' into feat_add_cache_for_secret
5d216cc 
* master: (134 commits)
  Record metric for service updates (dapr#5114)
  chore: remove duplicate word in comments (dapr#5099)
  Run e2e tests in previous version of K8s on AKS to see if it's breaking Windows tests (dapr#5104)
  add {namespace} option to set consumerID
  Add tracing passthrough for bindings (dapr#5049)
  Improve component init error logs and metrics (dapr#4975)
  Improvements to E2E test apps (dapr#5042)
  Fix component name for aws dynamodb (dapr#5095)
  Fix perf tests not building (dapr#5096)
  Fix missing components in Metadata API result. (dapr#5052)
  Fixed log message (dapr#5088)
  Disable IPFS binding for now (dapr#5092)
  optimize/concurrency: pubsub concurrency map writes in runtime unit test. (dapr#5086)
  Configuration API response to use dictionaries - based on PR dapr#4695 (dapr#5083)
  correct compile error
  correct checking for actors with same id
  fix type error in print
  fix typo
  add log when actor start time and end time is not expected
  Components auto-registration (dapr#5062)
  ...

Signed-off-by: zhangchao <zchao9100@gmail.com>

# Conflicts:
#	go.mod
#	pkg/grpc/api.go
#	pkg/grpc/api_test.go
#	pkg/http/api.go
#	pkg/runtime/runtime.go
@yaron2 yaron2 added this to the v1.9 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@artursouza artursouza artursouza approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@johnewart johnewart

Labels
None yet
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@johnewart @artursouza @dapr-bot @yaron2