Skip to content

optimize/concurrency: pubsub concurrency map writes in runtime unit test. #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 29, 2022
Merged

optimize/concurrency: pubsub concurrency map writes in runtime unit test. #5086

merged 6 commits into from
Aug 29, 2022

Conversation

1046102779
Copy link
Member

image
image

@1046102779 1046102779 requested review from a team as code owners August 26, 2022 08:58
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #5086 (214ae99) into master (63c8979) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 214ae99 differs from pull request most recent head 135ce32. Consider uploading reports for the commit 135ce32 to get more accurate results

@@            Coverage Diff             @@
##           master    #5086      +/-   ##
==========================================
+ Coverage   65.45%   65.47%   +0.02%     
==========================================
  Files         113      113              
  Lines       12721    12721              
==========================================
+ Hits         8326     8329       +3     
+ Misses       3811     3809       -2     
+ Partials      584      583       -1     
Impacted Files Coverage Δ
pkg/actors/internal/placement.go 89.11% <0.00%> (+1.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@addjuarez
Copy link
Contributor

LGTM

@artursouza
Copy link
Contributor

/ok-to-test

1 similar comment
@artursouza
Copy link
Contributor

/ok-to-test

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

End-to-end tests failed on linux. Please check the build logs

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

End-to-end tests failed on windows. Please check the build logs

@daixiang0
Copy link
Member

/ok-to-test

@artursouza artursouza merged commit 26fdbd1 into dapr:master Aug 29, 2022
@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

Taction added a commit to Taction/dapr that referenced this pull request Sep 5, 2022
* master: (134 commits)
  Record metric for service updates (dapr#5114)
  chore: remove duplicate word in comments (dapr#5099)
  Run e2e tests in previous version of K8s on AKS to see if it's breaking Windows tests (dapr#5104)
  add {namespace} option to set consumerID
  Add tracing passthrough for bindings (dapr#5049)
  Improve component init error logs and metrics (dapr#4975)
  Improvements to E2E test apps (dapr#5042)
  Fix component name for aws dynamodb (dapr#5095)
  Fix perf tests not building (dapr#5096)
  Fix missing components in Metadata API result. (dapr#5052)
  Fixed log message (dapr#5088)
  Disable IPFS binding for now (dapr#5092)
  optimize/concurrency: pubsub concurrency map writes in runtime unit test. (dapr#5086)
  Configuration API response to use dictionaries - based on PR dapr#4695 (dapr#5083)
  correct compile error
  correct checking for actors with same id
  fix type error in print
  fix typo
  add log when actor start time and end time is not expected
  Components auto-registration (dapr#5062)
  ...

Signed-off-by: zhangchao <zchao9100@gmail.com>

# Conflicts:
#	go.mod
#	pkg/grpc/api.go
#	pkg/grpc/api_test.go
#	pkg/http/api.go
#	pkg/runtime/runtime.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants