Fix missing components in Metadata API result. #5052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5052 +/- ##
==========================================
- Coverage 65.47% 65.46% -0.02%
==========================================
Files 113 113
Lines 12723 12725 +2
==========================================
- Hits 8331 8330 -1
- Misses 3809 3811 +2
- Partials 583 584 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Fixed #4963 |
7 tasks
|
Looks fine, no problems here. |
Dapr's GRPC Metadata API was never returning the list of registered component. That happened because the API object had a `components` attribute that was never assigned during API construction - it received a `getComponentsFn` but that one was also never invoked. This PR addressed this by aligning its implementation with its HTTP counterpart - removing the `components` attribute and using the `getComponentsFn` provided to the constructor instead. Fixes dapr#5051 Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
f6b2422 to
dbc3888
Compare
daixiang0
approved these changes
Aug 29, 2022
Taction
added a commit
to Taction/dapr
that referenced
this pull request
Sep 5, 2022
* master: (134 commits) Record metric for service updates (dapr#5114) chore: remove duplicate word in comments (dapr#5099) Run e2e tests in previous version of K8s on AKS to see if it's breaking Windows tests (dapr#5104) add {namespace} option to set consumerID Add tracing passthrough for bindings (dapr#5049) Improve component init error logs and metrics (dapr#4975) Improvements to E2E test apps (dapr#5042) Fix component name for aws dynamodb (dapr#5095) Fix perf tests not building (dapr#5096) Fix missing components in Metadata API result. (dapr#5052) Fixed log message (dapr#5088) Disable IPFS binding for now (dapr#5092) optimize/concurrency: pubsub concurrency map writes in runtime unit test. (dapr#5086) Configuration API response to use dictionaries - based on PR dapr#4695 (dapr#5083) correct compile error correct checking for actors with same id fix type error in print fix typo add log when actor start time and end time is not expected Components auto-registration (dapr#5062) ... Signed-off-by: zhangchao <zchao9100@gmail.com> # Conflicts: # go.mod # pkg/grpc/api.go # pkg/grpc/api_test.go # pkg/http/api.go # pkg/runtime/runtime.go
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dapr's GRPC Metadata API was never returning the list of registered components. That happened because the API object had a
componentsattribute that was never assigned during API object construction - it received agetComponentsFnbut that one was also never invoked.This PR addresses this by aligning GRPC implementation for this method with its HTTP counterpart - removing the
componentsattribute and using thegetComponentsFnprovided to the constructorinstead.
Fixes #5051
Issue reference
Please reference the issue this PR will close: #5051
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number][ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number][ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]