resiliency.PolicyDefined returns the policy object
#5050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spin-off from dapr#4903 Co-authored-by: Hal Spang <halspang@microsoft.com> Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #5050 +/- ##
==========================================
+ Coverage 65.32% 65.40% +0.08%
==========================================
Files 114 114
Lines 12650 12684 +34
==========================================
+ Hits 8263 8296 +33
- Misses 3798 3799 +1
Partials 589 589
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…iliency-policy
mukundansundar
approved these changes
Aug 20, 2022
| @@ -840,6 +897,11 @@ func (e *circuitBreakerInstances) Remove(name string) { | |||
| e.Unlock() | |||
| } | |||
|
|
|||
| // HasRetries returns true if the policy is configured to have more than 1 retry. | |||
| func (p PolicyDescription) HasRetries() bool { | |||
There was a problem hiding this comment.
any specific reason this has to be an exported function in this PR?
There was a problem hiding this comment.
That is needed in #4903
artursouza
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another spin-off from #4903
It changes the
resiliency.PolicyDefinedmethod to return the actual policy object and not just a boolean indicating whether a policy exists.This was necessary for #4903, but I co-authored this change with @halspang who said he thinks we need this for other things too, in the future.