Initialize metrics prior to loading resiliency #5730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the linter issues then LGTM |
Codecov Report
@@ Coverage Diff @@
## master #5730 +/- ##
==========================================
- Coverage 65.33% 64.80% -0.53%
==========================================
Files 151 151
Lines 15697 15851 +154
==========================================
+ Hits 10255 10273 +18
- Misses 4723 4858 +135
- Partials 719 720 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ItalyPaleAle
previously approved these changes
Jan 9, 2023
mukundansundar
previously approved these changes
Jan 10, 2023
DeepanshuA
previously approved these changes
Jan 10, 2023
Resiliency was being loaded before the actual metric views/fields were being init. This caused the Resiliency init metric to be lost. This commit moves the init up a bit to go before Resiliency. dapr#5711 Signed-off-by: halspang <halspang@microsoft.com>
fb9b316
daixiang0
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resiliency was being loaded before the actual metric views/fields were being init. This caused the Resiliency init metric to be lost. This commit moves the init up a bit to go before Resiliency.
#5711
Signed-off-by: halspang halspang@microsoft.com
Issue reference
Please reference the issue this PR will close: #5711
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: