Fix profile port #5707
Merged
Fix profile port #5707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2023
|
Currently dapr/dapr@master is broken and cannot be used in contrib for certification tests (causing a fatal error starting the profiling server). This fixes that. Please merge as soon as possible @daixiang0 @yaron2 @artursouza This will unblock others like @DeepanshuA |
Codecov Report
@@ Coverage Diff @@
## master #5707 +/- ##
==========================================
- Coverage 64.67% 64.64% -0.03%
==========================================
Files 150 150
Lines 15734 15734
==========================================
- Hits 10176 10172 -4
- Misses 4834 4838 +4
Partials 724 724
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks @ItalyPaleAle @berndverst @daixiang0 for quick investigation, fix and merge. It really helps to move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression (typo) introduced in #5648 . This is the reason for the test failures in components-contrib (see dapr/components-contrib#2405 )