Support for sharing extend metadata between grpc and http #4963
Conversation
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
| } | ||
|
|
||
| // MetadataGet get metadata of sidecar. | ||
| func (m *DefaultStore) MetadataGet() (map[string]string, error) { |
There was a problem hiding this comment.
Always nil error? Could we remove it?
There was a problem hiding this comment.
If the follow-up is no longer in-memory storage, it may no longer be a nil error.
There was a problem hiding this comment.
Is there any plan metadata stored in something else rather than in-memory storage?
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4963 +/- ##
==========================================
- Coverage 64.86% 64.79% -0.07%
==========================================
Files 151 151
Lines 15810 15815 +5
==========================================
- Hits 10255 10248 -7
- Misses 4833 4843 +10
- Partials 722 724 +2
|
Signed-off-by: crazyhzm <crazyhzm@gmail.com> # Conflicts: # pkg/runtime/runtime.go
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com> # Conflicts: # pkg/grpc/api.go # pkg/grpc/api_test.go
|
@CrazyHZM there are failing tests, please check. |
Signed-off-by: crazyhzm <crazyhzm@gmail.com> # Conflicts: # pkg/grpc/api.go # pkg/grpc/api_test.go
|
@yaron2 This failing test has nothing to do with this PR. |
That's correct. |
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
…/support_metadata Signed-off-by: crazyhzm <crazyhzm@gmail.com>
|
/ot-to-test |
Signed-off-by: crazyhzm <crazyhzm@gmail.com> # Conflicts: # pkg/grpc/api.go # pkg/grpc/api_test.go # pkg/http/api.go
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
…/support_metadata
Signed-off-by: crazyhzm <crazyhzm@gmail.com> # Conflicts: # pkg/grpc/api.go # pkg/grpc/api_test.go # pkg/http/api.go # pkg/http/api_test.go # pkg/runtime/runtime.go
|
@CrazyHZM can you please resolve the conflicts? |
Signed-off-by: crazyhzm <crazyhzm@gmail.com> # Conflicts: # pkg/grpc/api.go # pkg/http/api.go
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
|
Done @yaron2 |
Signed-off-by: crazyhzm <crazyhzm@gmail.com> # Conflicts: # pkg/runtime/runtime.go
|
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 67 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 67 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
There are already too many conflicts in this PR. I will close this pr first and look at the problem again. |
Signed-off-by: crazyhzm crazyhzm@gmail.com
Description
Issue reference
Please reference the issue this PR will close: #4941
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: