Skip to content

Conversation

hypernova3
Copy link

@hypernova3 hypernova3 commented Jul 5, 2022

Description

for dapr/components-contrib#1849

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@hypernova3 hypernova3 requested review from a team as code owners July 5, 2022 15:07
@berndverst
Copy link
Member

Can you rebase this against what I have in #4982 or rebase against master once #4982 is merged please?

@hypernova3
Copy link
Author

@berndverst done

Signed-off-by: hypernova3 <108718961+hypernova3@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #4860 (5443b82) into master (16f32df) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 5443b82 differs from pull request most recent head e6c9dda. Consider uploading reports for the commit e6c9dda to get more accurate results

@@            Coverage Diff             @@
##           master    #4860      +/-   ##
==========================================
- Coverage   65.57%   65.54%   -0.04%     
==========================================
  Files         112      112              
  Lines       12332    12320      -12     
==========================================
- Hits         8087     8075      -12     
+ Misses       3669     3668       -1     
- Partials      576      577       +1     
Impacted Files Coverage Δ
pkg/actors/internal/placement.go 87.56% <0.00%> (-1.56%) ⬇️
pkg/grpc/api.go 72.69% <0.00%> (-0.20%) ⬇️
pkg/grpc/endpoints.go 100.00% <0.00%> (ø)
pkg/runtime/cli.go 2.15% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants