Skip to content

array: add constants #11287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2024
Merged

array: add constants #11287

merged 1 commit into from
Aug 9, 2024

Conversation

lucascolley
Copy link
Contributor

@lucascolley lucascolley commented Aug 8, 2024 •
edited
Loading

Hi @jacobtomlinson, I've been testing dask.array in scipy/scipy#20956 and another thing that would be useful is to add these constants. newaxis is just an alias for None for use in indexing.

Similarly to the dtypes, these are the same objects across NumPy, CuPy and Sparse. Should be good to add as well?

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

jacobtomlinson
jacobtomlinson reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me.

If you look at cupy as an example it seems to expose more things from numpy than we are exposing here.

Does it make sense to make things consistent with cupy and expose the same things?

@lucascolley
Copy link
Contributor Author

Does it make sense to make things consistent with cupy and expose the same things?

Sure, I'll add in euler_gamma 👍

@lucascolley lucascolley mentioned this pull request Aug 8, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     13 files  ±0       13 suites  ±0   2h 58m 1s ⏱️ + 1m 8s
 13 131 tests ±0   12 063 ✅ ±0   1 068 💤 ±0  0 ❌ ±0 
136 827 runs  ±0  117 760 ✅  - 2  19 067 💤 +2  0 ❌ ±0 

Results for commit 447a85a. ± Comparison against base commit ed5f688.

@phofl phofl merged commit 1ba9c5b into dask:main Aug 9, 2024
23 checks passed
@phofl
Copy link
Collaborator

phofl commented Aug 9, 2024

thx

@lucascolley lucascolley deleted the constants branch August 9, 2024 11:58
@lucascolley lucascolley mentioned this pull request Jan 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucascolley @GPUtester @phofl @jacobtomlinson