Skip to content

V0.12.1.x voting fix #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2016
Merged

V0.12.1.x voting fix #783

merged 3 commits into from
May 20, 2016

Conversation

eduffield222
Copy link

  • Disabled flatfile dat checking on write, something is weird with the code and it's causing the data to be overwritten. I kept getting the same file that was loaded, instead of what was in memory until I disabled it.
  • Fixed various issues with voting and vote storage

@UdjinM6
Copy link

UdjinM6 commented May 19, 2016 •
edited
Loading

re flatdb bug:
this https://github.com/dashpay/dash/pull/783/files#diff-e47b970834e9f3ce2851cbc194434a41L204

ReadResult readResult = Read(objToSave, true);

should be smth like

T tmpObjToLoad;
ReadResult readResult = Read(tmpObjToLoad, true);

@UdjinM6 UdjinM6 mentioned this pull request May 20, 2016
Merged
@UdjinM6
Copy link

UdjinM6 commented May 20, 2016

provided a fix for flat-db I mentioned earlier in #785 , pls drop 49b8123 from this PR

@eduffield222 eduffield222 merged commit 49b8123 into dashpay:v0.12.1.x May 20, 2016
@eduffield222 eduffield222 deleted the v0.12.1.x-voting-fix branch May 23, 2016 18:12
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 25, 2024
@hebasto @PastaPastaPasta
Merge bitcoin-core/gui#795: Keep focus on "Hide" while ModalOverlay i…
62810bc 
…s visible

992b1bb qt: keep focus on "Hide" while ModalOverlay is visible (Jadi)

Pull request description:

  During the initial sync, the Tab moves the focus to the widgets of the main window, even when the ModalOverlay is visible. This creates some weird rectangular *selections on the screen*.

  This PR fixes this by keeping the focus on the "Hide" button while the ModalOverlay is visible.

  Fixes dashpay#783

ACKs for top commit:
  pablomartin4btc:
    Concept & approach ACK 992b1bb
  hebasto:
    re-ACK 992b1bb

Tree-SHA512: f702a3fd51db4bc10780bccf76394e35a6b5fb45db72c9c23cd10d777106b08c61077d2d989003838921e76d2cb44f809399f31df76448e4305a6c2a71b5c6a3
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 27, 2024
@hebasto @PastaPastaPasta
Merge bitcoin-core/gui#795: Keep focus on "Hide" while ModalOverlay i…
4e144be 
…s visible

992b1bb qt: keep focus on "Hide" while ModalOverlay is visible (Jadi)

Pull request description:

  During the initial sync, the Tab moves the focus to the widgets of the main window, even when the ModalOverlay is visible. This creates some weird rectangular *selections on the screen*.

  This PR fixes this by keeping the focus on the "Hide" button while the ModalOverlay is visible.

  Fixes dashpay#783

ACKs for top commit:
  pablomartin4btc:
    Concept & approach ACK 992b1bb
  hebasto:
    re-ACK 992b1bb

Tree-SHA512: f702a3fd51db4bc10780bccf76394e35a6b5fb45db72c9c23cd10d777106b08c61077d2d989003838921e76d2cb44f809399f31df76448e4305a6c2a71b5c6a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduffield222 @UdjinM6