Skip to content

Revert "Merge #6588: ci: attempt to fix docker builds by building arm64 and amd64 separately" #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

Revert "Merge #6588: ci: attempt to fix docker builds by building arm64 and amd64 separately" #6589

merged 1 commit into from
Feb 19, 2025

Conversation

PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented Feb 19, 2025 •
edited
Loading

What was done?

This reverts commit db0df3c, reversing changes made to b6ea178.

How Has This Been Tested?

The changes in develop before this commit were sufficient for fixing the release

diff is empty between: https://github.com/dashpay/dash/compare/b6ea17831e4a5f2c9378eb048a801a48eaed574d..e2278979dfec80d662f36ccc737fe2c7d4261ff9

Breaking Changes

None

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta
Revert "Merge dashpay#6588: ci: attempt to fix docker builds by build…
e227897 
…ing arm64 and amd64 separately"

This reverts commit db0df3c, reversing
changes made to b6ea178.
@PastaPastaPasta PastaPastaPasta added this to the 23 milestone Feb 19, 2025
@PastaPastaPasta PastaPastaPasta merged commit 1db6743 into dashpay:develop Feb 19, 2025
18 of 22 checks passed
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The GitHub Actions workflow for releasing to Docker Hub has been modified to consolidate architecture-specific tasks into a single job. The previous separate jobs for amd64 and arm64 have been removed. In the revised configuration, a unified job named "release" is now used to perform the release process. The updated workflow includes steps such as checking out the repository, setting up QEMU for multi-platform builds, and configuring Docker Buildx. The login step for Docker Hub remains unchanged. Steps for setting the raw tag, suffix, and Docker tags and labels have been retained. Additionally, the build and push step now handles both linux/amd64 and linux/arm64 using the platforms parameter. As part of the changes, references to job names and step IDs specific to a single architecture have been updated, and the output reference for the image digest has been modified accordingly.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db0df3c and e227897.

📒 Files selected for processing (1)
  • .github/workflows/release_docker_hub.yml (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23
Development

Successfully merging this pull request may close these issues.
1 participant
@PastaPastaPasta