backport: merge bitcoin#27479, #27230, #25251, partial #22934, #23383, #24792, #26691, #27445 (secp256k1 update) #5575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
6fa8ce2 to
147477e
Compare
|
I don't love that most of the commits are partials.. |
Neither do I but as long as Taproot support isn't in the codebase, they will remain partials. This was also the case in #4332. We could halt work on BIP324 until Taproot support reaches where we'd like it to be but BIP324 has active benefits and complements other Dash capabilities while Taproot alone, is passively beneficial. But yes, it is still undesirable to have to complete these backports in tandem with Taproot backports. |
5 tasks
UdjinM6
previously approved these changes
Nov 15, 2023
|
rebased from GH GUI to fix |
|
This pull request has conflicts, please rebase. |
|
force-pushed to resolve merge conflicts |
PastaPastaPasta
approved these changes
Nov 21, 2023
…Schnorr notes: - excludes changes done to `SignSchnorr`
taken from changes made to `configure.ac` in 0664f5f (bitcoin#19953)
…m secp256k1 changes
…on 0.2.0
notes:
- excludes changes made to `SignSchnorr`, `XOnlyPubKey`, kernel context and absent {fuzz,bench} tests
965b05e to
00b3dd6
Compare
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in https://github.com/dashpay/dash-issues/issues/7, bitcoin#27479 is an important backport required in establishing the cryptographic foundation needed for BIP324 support. This pull request, therefore, performs out-of-order updates of the
secp256k1subtree and its API use till bitcoin#27479.Additional information