Skip to content

merge bitcoin#15118, #14172, #15623, #14121, partial #13743, partial #15280: block filters #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2021
Merged

merge bitcoin#15118, #14172, #15623, #14121, partial #13743, partial #15280: block filters #4314

merged 6 commits into from
Aug 13, 2021

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Aug 2, 2021

No description provided.

@kwvg kwvg changed the title bitcoin#15118, 14172, 15623, 14121: block filters bitcoin#15118, #14172, #15623, #14121: block filters Aug 2, 2021
@kwvg kwvg changed the title bitcoin#15118, #14172, #15623, #14121: block filters merge bitcoin#15118, #14172, #15623, #14121: block filters Aug 2, 2021
@PastaPastaPasta PastaPastaPasta added this to the 18 milestone Aug 2, 2021
PastaPastaPasta
PastaPastaPasta requested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@PastaPastaPasta PastaPastaPasta added the RPC Some notable changes to RPC params/behaviour/descriptions label Aug 2, 2021
@PastaPastaPasta
Copy link
Member

Also, see https://github.com/PastaPastaPasta/dash/commits/pr_4314 for two backports that fixes the unit test problems in CI right now

PastaPastaPasta
PastaPastaPasta previously approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta dismissed their stale review August 6, 2021 22:14

I forgot about some of my comments 🙈

UdjinM6
UdjinM6 reviewed Aug 11, 2021
View reviewed changes
PastaPastaPasta
PastaPastaPasta approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

UdjinM6
UdjinM6 approved these changes Aug 13, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 changed the title merge bitcoin#15118, #14172, #15623, #14121: block filters merge bitcoin#15118, #14172, #15623, #14121, partial #13743, partial #15280: block filters Aug 13, 2021
@UdjinM6 UdjinM6 merged commit 607bd4b into dashpay:develop Aug 13, 2021
@kwvg kwvg deleted the blockfilters branch July 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
18
Development

Successfully merging this pull request may close these issues.
5 participants
@kwvg @PastaPastaPasta @UdjinM6 @ken2812221 @promag