Skip to content

backport: bitcoin#21694 (Use XLIFF file to provide more context to Transifex) #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2022
Merged

backport: bitcoin#21694 (Use XLIFF file to provide more context to Transifex) #4882

merged 2 commits into from
Jul 13, 2022

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Jun 11, 2022

@kwvg kwvg requested review from PastaPastaPasta and UdjinM6 June 11, 2022 15:30
@PastaPastaPasta
Copy link
Member

please mark as ready to review once 4830 is merged

@PastaPastaPasta PastaPastaPasta marked this pull request as draft June 23, 2022 00:01
@kwvg kwvg marked this pull request as ready for review July 3, 2022 17:28
@UdjinM6
Copy link

UdjinM6 commented Jul 8, 2022

why 32b3c2d? we don't do any translation thing in ci afaik

@kwvg
Copy link
Collaborator Author

kwvg commented Jul 8, 2022 •
edited
Loading

Because the Docker container does more than CI ever since #4336 was merged. It now serves as a "base container" which can be appropriated for CI or development, I use it for the latter and to generate the contents of 26fa69b, I was required to add support for it in the base container.

UdjinM6
UdjinM6 approved these changes Jul 8, 2022
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, utACK

@UdjinM6 UdjinM6 added this to the 18.1 milestone Jul 8, 2022
PastaPastaPasta
PastaPastaPasta approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta merged commit 6c0a633 into dashpay:develop Jul 13, 2022
@kwvg kwvg deleted the xliff_update branch July 18, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kwvg @PastaPastaPasta @UdjinM6