Open "Peers list" page when clicking on connections icon in status bar #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: Sorry for the commit spam at the end, I moved bitcoingui.cpp to the wrong folder :-/ |
|
Button works for me but tooltip background is transparent now and looks weird imo |
|
Seems to be an OSX thing (again), Linux looks 'normal': I'll check and report back when the OSX-build is fixed. |
|
Hi @UdjinM6 , |
|
|
|
Longest sec ever :-) ...in the meantime I found out that the OSX tooltips are "lightgoldenrodyellow" and installed the build-environment for the native OSX wallet so I don't have to rely on Gitian which half of the time fails...much faster this way :-) |
fix tooltip background
|
I built it on both OSX and Linux and it looks fine 👍 Ready to merge :-) |
UdjinM6
added a commit
that referenced
this pull request
May 20, 2015
Open "Peers list" page when clicking on connections icon in status bar
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Dec 21, 2022
* Use native job cancellation * Add start to js bindings workflow * Get the version info for a tag and replace in package.json * Add/update setup-emsdk action * Update artifact dir * Set NPM TOKEN in the publish step * Remove upload artifacts * Fix dir * publish packages as public * Actually use npm token * Fix cleanup file location
PastaPastaPasta
added a commit
that referenced
this pull request
Aug 21, 2024
…, #362, #828, bitcoin#21912, bitcoin#21942, bitcoin#21988 c7d3161 Merge bitcoin-core/gui#362: Add keyboard shortcuts to context menus (Hennadii Stepanov) 25f87b9 Merge bitcoin-core/gui#121: Early subscribe core signals in transaction table model (Hennadii Stepanov) ed56e28 Merge bitcoin-core/gui#335: test: Use QSignalSpy instead of QEventLoop (Hennadii Stepanov) c52b756 Merge bitcoin-core/gui#281: set shortcuts for console's resize buttons (W. J. van der Laan) b442a59 Merge bitcoin#21988: doc: note that brew installed qt is not supported (W. J. van der Laan) 0e2e315 Merge bitcoin#21942: docs: improve make with parallel jobs description. (MarcoFalke) c2735a8 Merge bitcoin#21912: doc: Remove mention of priority estimation (W. J. van der Laan) 1d56d20 Merge bitcoin-core/gui#257: refactor: Use template function qOverload in signal-slot connections (Hennadii Stepanov) b5fb559 Merge bitcoin-core/gui#18: Add peertablesortproxy module (Hennadii Stepanov) 1cdd9fb refactor: use new QAction style for governance list and masternode list (Konstantin Akimov) 4f89c98 Merge bitcoin-core/gui#263: Revamp context menus (Hennadii Stepanov) c36bb8e fix: use && in governance urls instead & (Konstantin Akimov) 1e585b1 Merge bitcoin-core/gui#828: Rendering an amp characters in the wallet name for QMenu (Hennadii Stepanov) Pull request description: ## Issue being fixed or feature implemented Just regular backports from bitcoin v22, mostly Qt related ## What was done? See commits for a list of backports. This PR also fixes a rendering an url on Governance tab if it has any '&' inside. see screenshots. Original url: `https://example.com/?test=nothing&to=see&&lol` - yes, double '&&' just for test even if url is silly. Failed behaviour:  Correctly rendered:  ## How Has This Been Tested? Run unit/functional tests ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: PastaPastaPasta: utACK c7d3161 UdjinM6: utACK c7d3161 Tree-SHA512: 67e7e8e0ec1a768d1f13baa48c123e4a415d3f32177a427d8117339a5eacf70864ebf46e9f1165bb8a3bf9c231f7929d33ac6aa19742e06a4e19d2f86dda6dc3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always wondered why the Bitcoin wallet does NOT offer this obvious action for that little connection icon down in the status bar...