Move DIP1 transaction size checks out of ContextualCheckBlock and use ContextualCheckTransaction instead #2238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we do with ContextualCheckBlock
…licating the check
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Apr 25, 2019
… ContextualCheckTransaction instead (dashpay#2238) * Pass consensus params to ContextualCheckTransaction As we do with ContextualCheckBlock * Use ContextualCheckTransaction in ContextualCheckBlock instead of duplicating the check * Fix pindexPrev parameter signature in ContextualCheckTransaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from the DIP3 branch. In DIP3, I added additional contextual checks for DIP3 into ContextualCheckTransaction. As ContextualCheckBlock also has to do the same checks, I'm calling ContextualCheckTransaction from there now, so that the later addition of new checks is handled well.