-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Allow consuming specific UTXO in gobject prepare command #2482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow consuming specific UTXO in gobject prepare command #2482
Conversation
d400987
to
e9d19e5
Compare
Rebased and ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below
Co-Authored-By: PastaPastaPasta <pasta@dashboost.org>
Co-Authored-By: PastaPastaPasta <pasta@dashboost.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
Co-Authored-By: PastaPastaPasta <pasta@dashboost.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added suggestions
Co-Authored-By: PastaPastaPasta <pasta@dashboost.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Use-IS (dashpay/dash#2452) Use specific UTXO for fee (dashpay/dash#2482)
* Content - RPC - Update quick reference * RPC - Update getblockchaininfo to show BIP-9 progress Related to dashpay/dash#2435 * RPC - Update gobject prepare with new params Use-IS (dashpay/dash#2452) Use specific UTXO for fee (dashpay/dash#2482) * RPC - Update mode name * RPC - Update protx default mode dashpay/dash#2513 * Content - Add spork 17 * Content - Special transactions Add info for Quorum commitment Remove messages not in 13.0 (SubTx) * P2P - Add new txlvote fields masternodeProTxHash (dashpay/dash#2484) quorumModifierHash (dashpay/dash#2505) * RPC - Update protx list Make all options follow the same parameter format (dashpay/dash#2559) * Content - version bump 0.13.0.0 bumped to 70213 (dashpay/dash#2557) * Guide - PrivateSend dstx message limit Up to 5 simultaneous dstxs per MN allowed (dashpay/dash#2552) * RPC - Update getblock Add missing versionHex field (dashpay/dash@e7d9ffa) Change to use verbosity syntax (dashpay/dash#2506 and bitcoin/bitcoin#8704) * P2P - Add qfcommit message (no hexdump example) DIP6 quorum final commitment (dashpay/dash#2477) * P2P - qfcommit typo Change description of llmqType field * P2P - Special tx payload size clarification * Guide - Update MN payment description Related to dashpay/dash#2258 * Guide - fix broken link * Guide - Update some example txs Change to hashes on the chain following the 12.3.4 reset * P2P - Add QcTx hexdump * P2P - DIP4 message updates Add SML entry Update hexdump to include new fields Add getmnlistd and mnlistdiff to cross ref * P2P - minor DIP3-related comments
* Implement optional CoinControl for gobject prepare * Removes duplicate `);` from merge error Co-Authored-By: PastaPastaPasta <pasta@dashboost.org> * Fix equality check allowing more relevant help output * Pass COutPoint as const reference Co-Authored-By: PastaPastaPasta <pasta@dashboost.org> * Remove unnecessary SetNull call Co-Authored-By: PastaPastaPasta <pasta@dashboost.org> * Specify proposal fee Co-Authored-By: PastaPastaPasta <pasta@dashboost.org>
Made from request of DashNexus folks
tested and working as expected
Conflicts with #2452 and potentially #2480 will rebase and force push after those are merged.Only commit for review for this PR d400987