Skip to content

Conversation

codablock
Copy link

I couldn't find a way to figure out the current progress of BIP9 deployments with Dash Core, so I hope this helps others as well.

This gives the count of blocks that voted for the given BIP9 deployment
@UdjinM6
Copy link

UdjinM6 commented Nov 10, 2018

I like the idea in general but I'd like to propose a couple of patches:
17fb6f2 - to make it look more consistent with the rest of the code
cc9523e - an additional (internal) check that we are not counting blocks for some another state
478c25d - to match rpc help (between 0 and 1)

@UdjinM6
Copy link

UdjinM6 commented Nov 10, 2018

Might also be a good idea to add a couple of tests in versionbits_tests.cpp.

@UdjinM6
Copy link

UdjinM6 commented Nov 12, 2018

ok, I guess you can ignore the first two :)

@codablock
Copy link
Author

added the last commit

@UdjinM6 UdjinM6 added this to the 13.0 milestone Nov 12, 2018
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@UdjinM6 UdjinM6 merged commit 3685c85 into dashpay:develop Nov 12, 2018
thephez added a commit to dash-docs/dash-docs that referenced this pull request Dec 13, 2018
thephez added a commit to thephez/dash-docs that referenced this pull request Dec 13, 2018
thephez added a commit to dash-docs/dash-docs that referenced this pull request Dec 26, 2018
* Content - RPC - Update quick reference

* RPC - Update getblockchaininfo to show BIP-9 progress

Related to dashpay/dash#2435

* RPC - Update gobject prepare with new params

Use-IS (dashpay/dash#2452)
Use specific UTXO for fee (dashpay/dash#2482)

* RPC - Update mode name

* RPC - Update protx default mode

dashpay/dash#2513

* Content - Add spork 17

* Content - Special transactions

Add info for Quorum commitment
Remove messages not in 13.0 (SubTx)

* P2P - Add new txlvote fields

masternodeProTxHash (dashpay/dash#2484)
quorumModifierHash (dashpay/dash#2505)

* RPC - Update protx list

Make all options follow the same parameter format (dashpay/dash#2559)

* Content - version bump

0.13.0.0 bumped to 70213 (dashpay/dash#2557)

* Guide - PrivateSend dstx message limit

Up to 5 simultaneous dstxs per MN allowed (dashpay/dash#2552)

* RPC - Update getblock

Add missing versionHex field (dashpay/dash@e7d9ffa)
Change to use verbosity syntax (dashpay/dash#2506 and
bitcoin/bitcoin#8704)

* P2P - Add qfcommit message (no hexdump example)

DIP6 quorum final commitment (dashpay/dash#2477)

* P2P - qfcommit typo

Change description of llmqType field

* P2P - Special tx payload size clarification

* Guide - Update MN payment description

Related to dashpay/dash#2258

* Guide - fix broken link

* Guide - Update some example txs

Change to hashes on the chain following the 12.3.4 reset

* P2P - Add QcTx hexdump

* P2P - DIP4 message updates

Add SML entry
Update hexdump to include new fields
Add getmnlistd and mnlistdiff to cross ref

* P2P - minor DIP3-related comments
@codablock codablock deleted the pr_bip9_progress branch December 27, 2018 15:23
@UdjinM6 UdjinM6 mentioned this pull request Jun 23, 2019
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 23, 2019
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 24, 2019
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants