Skip to content

Undefine DOUBLE after include Chia BLS headers #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2018
Merged

Undefine DOUBLE after include Chia BLS headers #2400

merged 1 commit into from
Oct 31, 2018

Conversation

codablock
Copy link

These cause compilation errors on some platforms.
Observed this when I tried to cross compile win32
locally on a Debian Stretch machine.

@codablock
Undefine DOUBLE after include Chia BLS headers
fb150f2 
These cause compilation errors on some platforms.
Observed this when I tried to cross compile win32
locally on a Debian Stretch machine.
UdjinM6
UdjinM6 requested changes Oct 30, 2018
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

EDIT: oops, I mean "Approve" :)

@UdjinM6 UdjinM6 added this to the 13.0 milestone Oct 30, 2018
@codablock
Copy link
Author

FYI, this also fixes Gitian builds

@codablock codablock merged commit 70eb710 into dashpay:develop Oct 31, 2018
@codablock codablock deleted the pr_wincompilation_bls branch October 31, 2018 09:58
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Jun 29, 2020
@codablock @CryptoCentric
Undefine DOUBLE after include Chia BLS headers (dashpay#2400)
58b7f11 
These cause compilation errors on some platforms.
Observed this when I tried to cross compile win32
locally on a Debian Stretch machine.
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Jul 5, 2020
@codablock @CryptoCentric
Undefine DOUBLE after include Chia BLS headers (dashpay#2400)
9318da9 
These cause compilation errors on some platforms.
Observed this when I tried to cross compile win32
locally on a Debian Stretch machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@codablock @UdjinM6