-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[UI] In-wallet PrivateSend help #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@schinzelh , can you have a look at the Travis build? |
WTF - whitelisted packages... this is new... I'll consider migrating from Docker based Travis to native one.. |
Btw: They broke Ethereum builds as well |
From the description it sounds like mixing session is using 1 input from each participant and uses 1 address only which can mislead people thinking that "oh, well I have addresses for 1000 sessions, I shouldn't really care". In reality it can use up to 9 inputs per person in one mixing session iirc + it uses addresses for collaterals + sometimes mixing fails at later stage if smth goes wrong with creation of final tx (someone might be misbehaving or disconnected for some reason e.g. closed his wallet) i.e. user would see no "Denominate" tx but some of his addresses were already consumed. I think it worth fixing it at least by changing "one of your addresses" to "few of your addresses" and mentioning that such keypool size should be enough for ~100 mixing events. |
"Up to 9 inputs", together with "about 100 mixing events" sounds good to me. I'll change it later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Reference: https://www.dash.org/forum/threads/q3-core-team-report-call.11085/#post-106703 and https://www.dash.org/forum/threads/in-wallet-privatesend-help.11324/
Final text by ddlink7 (thanks a lot 👍 ).
Advanced PrivateSend interface with complete help text:

Simple PrivateSend interface:

The link at the end is clickable and goes to our Wiki.