Refactor CGovernanceManager::Sync (split in two) #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
approved these changes
Feb 12, 2018
| connman.PushMessage(pfrom, msgMaker.Make(NetMsgType::SYNCSTATUSCOUNT, MASTERNODE_SYNC_GOVOBJ_VOTE, nVoteCount)); | ||
| LogPrintf("CGovernanceManager::Sync -- sent %d objects and %d votes to peer=%d\n", nObjCount, nVoteCount, pfrom->id); | ||
| CNetMsgMaker msgMaker(pnode->GetSendVersion()); | ||
| connman.PushMessage(pnode, msgMaker.Make(NetMsgType::SYNCSTATUSCOUNT, MASTERNODE_SYNC_GOVOBJ, nObjCount)); |
There was a problem hiding this comment.
Not really related to this PR, but is the order in which SYNCSTATUSCOUNT and INV(MSG_GOVERNANCE_OBJECT) arrive in any way important? As I understand the code, there is no order guaranteed because inventories are sent/flushed in SendMessages, while SYNCSTATUSCOUNT is sent here immediately.
There was a problem hiding this comment.
SYNCSTATUSCOUNT is for informational purposes only, there is no special logic tied to it, and yes, it doesn't matter in which order they arrive.
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1929 , trying to make it easier to follow