Skip to content

Switch KeePassHttp integration to new AES lib, add tests and a note about KeePassHttp security #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2017
Merged

Switch KeePassHttp integration to new AES lib, add tests and a note about KeePassHttp security #1818

merged 3 commits into from
Dec 28, 2017

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 27, 2017

No description provided.

@UdjinM6 UdjinM6 added this to the 12.3 milestone Dec 27, 2017
@codablock
Copy link

Hmm, aren't the new tests in src/wallet/test/crypto_tests.cpp duplicating what src/test/crypto_tests.cpp already tests?

@UdjinM6
Copy link
Author

UdjinM6 commented Dec 27, 2017 •
edited
Loading

Note quite. New tests test KeePassHttp specific functions making sure that old and new versions of them produce the same result, just like other tests for CCrypter in src/wallet/test/crypto_tests.cpp. src/test/crypto_tests.cpp only tests general (new) crypto lib functionality.

codablock
codablock approved these changes Dec 28, 2017
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 1448506 into dashpay:develop Dec 28, 2017
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@UdjinM6 @andvgal
Switch KeePassHttp integration to new AES lib, add tests and a note a…
8f40d5a 
…bout KeePassHttp security (dashpay#1818)

* Add a note about KeePassHttp security

* Use new AES lib instead of OpenSSL for KeePassHttp encryption/decryption

* Add tests to make sure new AES lib works corrctly for KeePassHttp encryption/decryption and produces the same results as OpenSSL did
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 15, 2019
@CryptoCentric
Switch KeePassHttp integration to new AES lib, add tests and a note a…
3a0078f 
…bout KeePassHttp security (dashpay#1818)

* Add a note about KeePassHttp security

* Use new AES lib instead of OpenSSL for KeePassHttp encryption/decryption

* Add tests to make sure new AES lib works corrctly for KeePassHttp encryption/decryption and produces the same results as OpenSSL did
@PastaPastaPasta PastaPastaPasta mentioned this pull request Feb 2, 2020
Merged
@UdjinM6 UdjinM6 deleted the keepassnewlibtestandanote branch November 26, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@codablock codablock codablock approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.3
Development

Successfully merging this pull request may close these issues.
2 participants
@UdjinM6 @codablock